Attention is currently required from: pespin, dexter.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/31174 )
Change subject: pcu_l1_if: receive E1 connection parameters
......................................................................
Patch Set 1:
(2 comments)
File src/pcu_l1_if.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/31174/comment/54f10418_91adae2c
PS1, Line 992: LOGP(DL1IF, LOGL_ERROR, "(PDCH-TS:%u, TRX:%u) cannot find E1
connection parameters for CCU\n", pdch_ts,
This logging prefixes are not following any existing
format in any osmocom code afaict.
Indeed, would be nice to have the format
consistent with LOGPDCH().
https://gerrit.osmocom.org/c/osmo-pcu/+/31174/comment/4505e414_120c7789
PS1, Line 1271: pcu_prim->u.info_ind
copy-paste, should be 'e1_ccu_ind' instead
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/31174
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I1f926b023205a9ecf78d8a8586d6ac21cc73eb0a
Gerrit-Change-Number: 31174
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 04 Feb 2023 19:03:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment