fixeria has uploaded this change for review. (
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39521?usp=email )
Change subject: {erab_fsm,sctp_proxy}: handle_event/4: fix return value
......................................................................
{erab_fsm,sctp_proxy}: handle_event/4: fix return value
When we do not reply, it must be an atom alone, not a tuple:
https://www.erlang.org/doc/apps/stdlib/gen_statem#t:state_callback_result/2
This patch fixes errors like this:
State machine <0.406.0> terminating.
Reason: {bad_return_from_state_function,{keep_state_and_data}}
Change-Id: Ib8c10e0b1d888e005a593644c0ecead560b2f2ce
Related: SYS#7318
---
M src/erab_fsm.erl
M src/sctp_proxy.erl
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/21/39521/1
diff --git a/src/erab_fsm.erl b/src/erab_fsm.erl
index e2f86c5..9a654e5 100644
--- a/src/erab_fsm.erl
+++ b/src/erab_fsm.erl
@@ -407,7 +407,7 @@
handle_event(State, Event, EventData, _S) ->
?LOG_ERROR("Unexpected event ~p in state ~p: ~p", [Event, State,
EventData]),
- {keep_state_and_data}.
+ keep_state_and_data.
code_change(_Vsn, State, S, _Extra) ->
diff --git a/src/sctp_proxy.erl b/src/sctp_proxy.erl
index 755d2a3..ed4af02 100644
--- a/src/sctp_proxy.erl
+++ b/src/sctp_proxy.erl
@@ -218,7 +218,7 @@
handle_event(State, Event, EventData, _S) ->
?LOG_ERROR("Unexpected event ~p in state ~p: ~p", [Event, State,
EventData]),
- {keep_state_and_data}.
+ keep_state_and_data.
code_change(_Vsn, State, S, _Extra) ->
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39521?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Ib8c10e0b1d888e005a593644c0ecead560b2f2ce
Gerrit-Change-Number: 39521
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>