Attention is currently required from: Hoernchen.
laforge has posted comments on this change by Hoernchen. (
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759?usp=email )
Change subject: Make ch9 usb tests work
......................................................................
Patch Set 1: Code-Review+1
(4 comments)
File contrib/ch9_epstall.py:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/b8bd9c0e_34…
:
PS1, Line 3: ch9 usb ep halt test
Does that test have a name/number? If so, it would be good to add as a spec reference.
File contrib/gdb_clocktree.py:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/3f466ed4_e3…
:
PS1, Line 1: import gdb
please add copyright/author and at least a brief summary.
File contrib/gdb_sercom.py:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/b44419f7_7e…
:
PS1, Line 1: import gdb
a line with author / copyright information is missing, and at least a very high-level
description of what it is about (yes something for gdb related to the SERCOM peripheral...
but what?)
File contrib/gdb_usb.py:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759/comment/481779de_5f…
:
PS1, Line 3:
same here: copyright/author/brief description
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39759?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Icadaee9d8cbe24bd3cac002cc4f710dcf846a32b
Gerrit-Change-Number: 39759
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 10 Mar 2025 17:49:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes