Attention is currently required from: arehbein, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31595 )
Change subject: osmo_wqueue_init(): Fix parameter type
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Is it that bad potentially breaking some compilation with strict type checks for this? Seems to me l […]
A simple typecast means all the potential users having to compile the app on their systems using some specific library version will suddenly make their compilation fail. Which means they have to find out why it doesn't compile, then make the change and even worse, try to find out how to make their app code work with both versions of the API.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/31595
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6c9295750e1755bf1d80f3a3b32efc2aefb11a57
Gerrit-Change-Number: 31595
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein
arehbein@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: laforge
laforge@osmocom.org
Gerrit-Attention: arehbein
arehbein@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Comment-Date: Thu, 02 Mar 2023 18:35:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein
arehbein@sysmocom.de
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Gerrit-MessageType: comment