Attention is currently required from: jolly, laforge.
pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40489?usp=email )
Change subject: Allow io_uring_submit batching just ahead of poll/select ......................................................................
Patch Set 5: Code-Review-1
(2 comments)
File src/core/osmo_io_uring.c:
https://gerrit.osmocom.org/c/libosmocore/+/40489/comment/1e55e1af_71945150?u... : PS4, Line 431: io_uring_submit(&g_ring.ring);
Done
Not done
https://gerrit.osmocom.org/c/libosmocore/+/40489/comment/023b9662_88a06ae9?u... : PS4, Line 481: io_uring_submit(&g_ring.ring); Since this pattern is repeated in several places, I'd add a static "inline void io_uring_sched_submit()" function which does this. Then we easily spot places where the same thing needs to be done, and we don't forget updating all of them like it happened already in this version of the patch.