Attention is currently required from: daniel, lynxis lazus.
fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37868?usp=email )
Change subject: move gsm48_gmm_att_tlvdef into gprs_gmm_util ......................................................................
Patch Set 15:
(4 comments)
File include/osmocom/sgsn/gprs_gmm_util.h:
https://gerrit.osmocom.org/c/osmo-sgsn/+/37868/comment/693a3aa5_ffce1f5e?usp... : PS15, Line 1: #ifndef _GPRS_GMM_UTIL_H `#pragma once`
https://gerrit.osmocom.org/c/osmo-sgsn/+/37868/comment/8a8c60c2_d2db8885?usp... : PS15, Line 6: struct msgb; Why adding it here?
File src/sgsn/gprs_gmm_util.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/37868/comment/e1617968_d4877d83?usp... : PS15, Line 9: Author: Alexander Couzens lynxis@fe80.eu `git-blame` tells me that Harald and Pau are the authors of code you're moving here.
https://gerrit.osmocom.org/c/osmo-sgsn/+/37868/comment/b97122e7_4c6d38e1?usp... : PS15, Line 25: #include <osmocom/gsm/gsm48.h> Unneeded import?