Attention is currently required from: fixeria, pespin, dexter.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/33448
)
Change subject: ASCI: Add Notification/FACCH support
......................................................................
Patch Set 6:
(3 comments)
File include/osmo-bts/notification.h:
https://gerrit.osmocom.org/c/osmo-bts/+/33448/comment/fc4a1947_2ff8fc2b
PS5, Line 60: int facch_gen_msg(struct gsm_bts *bts, uint8_t *out_buf, const uint8_t
*group_call_ref, const uint8_t *chan_desc,
As far as I understand this is an ASCI related
function. […]
Done
File src/common/rsl.c:
https://gerrit.osmocom.org/c/osmo-bts/+/33448/comment/f36a6db5_af29deaa
PS5, Line 814: broadcast_facch
Maybe it would be good to add a comment to clarify
this?
Done
https://gerrit.osmocom.org/c/osmo-bts/+/33448/comment/d28634e5_81a8f0c3
PS5, Line 814: static int broadcast_facch(struct gsm_bts *bts, const uint8_t
*group_call_ref, const uint8_t *chan_desc,
maybe rename this asci_broadcast_facch, so that it is
more clear that this function is asci related? […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/33448
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3ed14fa54a907891e492a7ada8e745a2c56cd46d
Gerrit-Change-Number: 33448
Gerrit-PatchSet: 6
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 19 Jul 2023 12:59:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment