Attention is currently required from: osmith, pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34575?usp=email )
Change subject: gprs_rlcmac_sched: check if we really use direct phy ......................................................................
Patch Set 3:
(1 comment)
File src/gprs_rlcmac_sched.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/34575/comment/041dbd01_b3941f83 PS2, Line 491: if (bts->trx[trx].fl1h) {
I think this is breaking/changing the behavior when osmo-bts-sysmo is used without direct-phy flag. […]
First of all: Yes, I also think the behavior is changed.
When we compile osmo-pcu with direct-phy support and osmo-bts-sysmo uses direct phy support we should be fine.
When we do not use direct phy support (does not matter whether it is compiled in or not), then skip_idle = skip_idle && trx != 0; is not executed. As far as I understand the PCU will then not generate the idle frames. Osmo-bts would do this then.
Or do you think that osmo-bts-sysmo needs the idle frames but osmo-bts-trx not? I am a bit lost here. I always thought the behaviour would be the same for all BTS models in that regard.