Attention is currently required from: jolly, laforge.
fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/37798?usp=email )
Change subject: After writing VTY config, run sync() in a different thread ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
while this is an improvement, we ideally would only call fsync on the one specific file, rather than […]
We had this discussion with @andreas@eversberg.eu in a call, and at first I was also under impression that this is complicating things and we should just go for `fsync()`. But then we checked the code and I found out that it's not just writing stuff to one file, but doing several fs operations: `mkstemp()`, write to it, `unlink()`, `stat()`, than `link()` and `unlink()`. This made me think that the code is doing `sync()` for a reason.