Attention is currently required from: fixeria.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35466?usp=email )
Change subject: core: osmo_tdef_fsm_inst_state_chg(): allow millisecond precision ......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS4: should we immediately improve to full microsecond granularity, as in not repeat the earlier mistake?
File src/core/tdef.c:
https://gerrit.osmocom.org/c/libosmocore/+/35466/comment/7903d0fc_8fdb90ee PS4, Line 347: val = osmo_tdef_get(tdefs, t->T, OSMO_TDEF_S, default_timeout); IIRC osmo_tdef_get(..., OSMO_TDEF_MS, ...) should do exactly what is intended here. why is the condition necessary / which corner case fails?