Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37958?usp=email )
Change subject: s1gw: Initial StatsD support
......................................................................
Patch Set 2:
(2 comments)
File s1gw/S1GW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37958/comment/f9a54fd9_9ce9…
:
PS2, Line 79: VirtHNBGW
copy-paste
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37958/comment/6ec41f4c_6ba5…
:
PS2, Line 112: f_new_ConnHdlrPars
[At least now] I don't really see the need for this function.
```
var ConnHdlrPars pars := valueof(t_ConnHdlrPars());
var ConnHdlrPars pars := f_new_ConnHdlrPars();
```
Does not worth it saving just a few chars...
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37958?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib98c2fe68006a8d0f45de6966927b349a3b933ca
Gerrit-Change-Number: 37958
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 02 Sep 2024 20:38:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No