14 Mar
2023
14 Mar
'23
1:51 a.m.
Attention is currently required from: pespin.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31664 )
Change subject: layer23: get rid of lapdm_channel_init() warning ......................................................................
Patch Set 3:
(1 comment)
File src/host/layer23/include/osmocom/bb/common/ms.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/31664/comment/01cf4760_e45ceb01 PS2, Line 106: enum gsm_chan_t chan_t, const char *name);
using chan_t for the name of the variable is confusing, it looks like you are passing a type. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31664
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: If3be53a9f20e0f9e7cfb9ccd04ed54a3dcde44b8
Gerrit-Change-Number: 31664
Gerrit-PatchSet: 3
Gerrit-Owner: msuraev msuraev@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Mon, 13 Mar 2023 14:51:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment