Attention is currently required from: fixeria, pespin.
jolly has posted comments on this change by jolly. (
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029?usp=email )
Change subject: Add unit tests for S1 HANDOVER procedure
......................................................................
Patch Set 2:
(5 comments)
File test/s1ap_proxy_test.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/9ef7a85c_46fb…
:
PS1, Line 380:
unrelated ws removal
Done
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/a136a4db_f2a9…
:
PS1, Line 76: peperation
prep{E->A}ration
Done
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/5aa77f79_8335…
:
PS1, Line 403: [?_assertMatch({forward, _}, s1ap_proxy:process_pdu(Pid,
HandoverRqd)),
:
Here we expect the PDUs to be forwarded as-is
(unmodified), right? […]
Done
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/ea92ac8f_a66f…
:
PS1, Line 413: HANDOVER REQUEST
This PDU actually goes from the MME to the target eNB,
so `[eNB <- MME]`.
Done
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/a9db5147_465d…
:
PS1, Line 416: MME -> eNB
... and the opposite direction here: `[eNB ->
MME]`.
Done
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I400ac73343f2a795c8206aeee75a31f1455adbd0
Gerrit-Change-Number: 41029
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 Sep 2025 11:23:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>