Attention is currently required from: fixeria, pespin.
jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029?usp=email )
Change subject: Add unit tests for S1 HANDOVER procedure ......................................................................
Patch Set 2:
(5 comments)
File test/s1ap_proxy_test.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/9ef7a85c_46fb4... : PS1, Line 380:
unrelated ws removal
Done
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/a136a4db_f2a94... : PS1, Line 76: peperation
prep{E->A}ration
Done
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/5aa77f79_83353... : PS1, Line 403: [?_assertMatch({forward, _}, s1ap_proxy:process_pdu(Pid, HandoverRqd)), :
Here we expect the PDUs to be forwarded as-is (unmodified), right? […]
Done
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/ea92ac8f_a66fa... : PS1, Line 413: HANDOVER REQUEST
This PDU actually goes from the MME to the target eNB, so `[eNB <- MME]`.
Done
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41029/comment/a9db5147_465d0... : PS1, Line 416: MME -> eNB
... and the opposite direction here: `[eNB -> MME]`.
Done