28 Sep
2023
28 Sep
'23
1:59 p.m.
Attention is currently required from: jolly.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34570?usp=email )
Change subject: Fix reception of MM messages at gsm48_mm_data_ind() ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File src/host/layer23/src/mobile/gsm48_mm.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/34570/comment/6400f0c6_cdc8b1ce PS1, Line 4091: switch (pdisc) { Sounds like you probably want to put all the code from here to line 4155 to a subfunction to simplify this one and avoid the goto. Can be done in another patch.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34570?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I263739bb0220d19f14114714fe9d82505bdbd267
Gerrit-Change-Number: 34570
Gerrit-PatchSet: 1
Gerrit-Owner: jolly andreas@eversberg.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: jolly andreas@eversberg.eu
Gerrit-Comment-Date: Thu, 28 Sep 2023 11:59:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment