Attention is currently required from: dexter, fixeria.
laforge has posted comments on this change by laforge. (
https://gerrit.osmocom.org/c/pysim/+/40236?usp=email )
Change subject: docs: Better python doc-strings for better pySim.esim manual
......................................................................
Patch Set 1:
(1 comment)
File pySim/esim/saip/templates.py:
https://gerrit.osmocom.org/c/pysim/+/40236/comment/a63561d5_a9d2342d?usp=em… :
PS1, Line 243: created_by_default = True
:
This looks weird. […]
yes, looks like it.
thanks!
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/40236?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I7be6264c665a2a25105681bb5e72d0f6715bbef8
Gerrit-Change-Number: 40236
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 07 May 2025 08:51:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>