Attention is currently required from: laforge, fixeria.
Hoernchen has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-trx/+/32762 )
Change subject: transceiver: pass cfg struct instead of args
......................................................................
Patch Set 4:
(4 comments)
Patchset:
PS4:
as per haralds comment we're gonna reformat everything in a followup patch
File Transceiver52M/device/uhd/UHDDevice.h:
https://gerrit.osmocom.org/c/osmo-trx/+/32762/comment/c44c5e11_107240a0
PS3, Line 83: uhd_device(InterfaceType iface, const struct trx_cfg *cfg);
tabs vs spaces inconsistency
Done
File Transceiver52M/device/usrp1/USRPDevice.h:
https://gerrit.osmocom.org/c/osmo-trx/+/32762/comment/70fa78c6_57d370c5
PS3, Line 107: USRPDevice(InterfaceType iface, const struct trx_cfg *cfg);
2 spaces vs 4 spaces inconsistency?
Done
https://gerrit.osmocom.org/c/osmo-trx/+/32762/comment/0525afd3_92e672b4
PS3, Line 120: return TX_WINDOW_USRP1;
what a mix
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-trx/+/32762
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I48386900d15ff4d770c70a4efc246d32f921904b
Gerrit-Change-Number: 32762
Gerrit-PatchSet: 4
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 27 Jul 2023 14:03:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment