Attention is currently required from: daniel.
wbokslag has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-tetra/+/28926 )
Change subject: when traffic dump directory is specified, now prints error message and
exits instead of crashing when traffic file cannot be written
......................................................................
Patch Set 4:
(1 comment)
File src/lower_mac/tetra_lower_mac.c:
https://gerrit.osmocom.org/c/osmo-tetra/+/28926/comment/e95722f0_2813fb14
PS3, Line 200: fprintf(stderr, "could not open dump file %s for writing\n",
fname);
You could use perror or a strerror variant to include
the reason it failed.
Good idea, pushed a revised version that prints the error
message through strerror
--
To view, visit
https://gerrit.osmocom.org/c/osmo-tetra/+/28926
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-tetra
Gerrit-Branch: master
Gerrit-Change-Id: I273e07aefd9faea13662f6699a6f3b074c8efe88
Gerrit-Change-Number: 28926
Gerrit-PatchSet: 4
Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 09 Aug 2022 15:31:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment