Attention is currently required from: pespin, dexter.
matanp has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/32498
)
Change subject: ctrl: Add penalty time control
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-bsc/+/32498/comment/6fef9071_9c383327
PS1, Line 7: ctrl: Add penalty time control
Maybe add some context here what "penalty
time" is for - apparently its it is some SI value.
Ack
File src/osmo-bsc/bts_ctrl.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/32498/comment/84a24cd5_8cf6cace
PS1, Line 796: CTRL_CMD_DEFINE(bts_penalty_time, "penalty-time");
Renaming the field to something more specific, like
si3-penalty time yes.
Ack
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/32498
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Idfdd54dec72fb5f52eee22df018161d75b8c48c8
Gerrit-Change-Number: 32498
Gerrit-PatchSet: 3
Gerrit-Owner: matanp <matan1008(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 26 Apr 2023 16:00:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Comment-In-Reply-To: matanp <matan1008(a)gmail.com>
Gerrit-MessageType: comment