Change in osmo-ttcn3-hacks[master]: bsc: move as_Media arg fail_on_dlcx to pars

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31337 ) Change subject: bsc: move as_Media arg fail_on_dlcx to pars ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: Right, the previous version would allow running as_Media() multiple times, once with fail_on_dlcx := false and once with true, inside the same test. But none of the existing tests make use of this, and I'm not sure if there would be practical use for it. Without this patch however it would be needed to carry the fail_on_dlcx parameter through: * f_tc_ho_into_this_bsc_main() * f_start_handler(refers(f_tc_ho_into_this_bsc), pars) * f_ho_into_this_bsc() And to pass it to f_tc_ho_into_this_bsc, it would needed to be added to pars anyway. So IMHO it makes more sense to just put it there and remove it from as_Media(), until the use case comes up at which point it would be added to as_Media() again in addition to the parameter being in pars. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31337 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6f0c4ce543724cc6f18bae9fc2b480f5818db8b7 Gerrit-Change-Number: 31337 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 16 Feb 2023 10:24:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment