Attention is currently required from: pespin.

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    I'm not sure this is improving the situation. […]

    Right, the previous version would allow running as_Media() multiple times, once with fail_on_dlcx := false and once with true, inside the same test. But none of the existing tests make use of this, and I'm not sure if there would be practical use for it.

    Without this patch however it would be needed to carry the fail_on_dlcx parameter through:

    • f_tc_ho_into_this_bsc_main()
    • f_start_handler(refers(f_tc_ho_into_this_bsc), pars)
    • f_ho_into_this_bsc()

    And to pass it to f_tc_ho_into_this_bsc, it would needed to be added to pars anyway. So IMHO it makes more sense to just put it there and remove it from as_Media(), until the use case comes up at which point it would be added to as_Media() again in addition to the parameter being in pars.

To view, visit change 31337. To unsubscribe, or for help writing mail filters, visit settings.