30 Jun
2023
30 Jun
'23
2:53 p.m.
Attention is currently required from: arehbein.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33195 )
Change subject: stream: Move some code in preparation of next commit ......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
ahh I see, by 'merge' you mean not to have declarations with different identifier prefixes alternate […]
yes, I mean don't mix/interleave functions pertaining to different objects. The idea is to have all code related to an object (client vs srv vs srv_link) separated in blocks.
We should ideally even move client in one .c file and srv + srv_link to another one at some point.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33195
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ic3f21967fe929b17327eb95739ace16c9734a151
Gerrit-Change-Number: 33195
Gerrit-PatchSet: 3
Gerrit-Owner: arehbein arehbein@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter pmaier@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: arehbein arehbein@sysmocom.de
Gerrit-Comment-Date: Fri, 30 Jun 2023 12:53:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein arehbein@sysmocom.de
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment