Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36317?usp=email )
Change subject: osmo-bts-virtual: Port over to osmo_io ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File src/osmo-bts-virtual/osmo_mcast_sock.c:
https://gerrit.osmocom.org/c/osmo-bts/+/36317/comment/4db83d2c_886f2839 PS2, Line 116: bidir_sock->read_cb = read_cb; I wonder whether we still really need to store this field here.
File src/osmo-bts-virtual/scheduler_virtbts.c:
https://gerrit.osmocom.org/c/osmo-bts/+/36317/comment/16ef2e81_d5dcfe6a PS2, Line 105: else if (rc == 0) why is this removed? because it cannot happen anymore right?