Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30926 )
Change subject: upf/PFCP: do not imply f_inet_addr() ......................................................................
Patch Set 2:
(3 comments)
File hnbgw/HNBGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30926/comment/ac6665f2_8ac9e... PS2, Line 1318: var F_SEID up_f_seid := valueof(ts_PFCP_F_SEID_ipv4(f_inet_addr("127.0.0.1"), '1111111111111111'O));
tip: if you had written the templates below using "template (value)" as parameter you wouldn't need […]
yes i realized that recently, already changed the template. this caller didn't reflect that yet -- not related to this patch
File library/PFCP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30926/comment/c4b9c67a_ef243... PS2, Line 327: template (value) Outer_Header_Creation ts_PFCP_Outer_Header_Creation_GTP_ipv4(OCT4 remote_teid, OCT4 remote_addr_v4) := {
here, these params would better be "template (value)" so that they both accept "template (value)" an […]
seems odd for a "native" type like OCT4?
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30926/comment/83bfc739_54f06... PS2, Line 423: Create_PDR_list create_pdr,
same here, these can be "template (value)".
yes but separate patch