28 May
2024
28 May
'24
8:13 p.m.
Attention is currently required from: nt2mku.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email )
Change subject: gsm48_encode_bearer_cap(): omit octet 3a if only GSM-FR/GSM-HR v1 is
supported
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
Let's ensure test stability:
Our ttcn3 tests and possibly clients of libosmocore in regression tests expect specific
PDUs in specific scenarios. If we change the implicit behavior, then tests may fall on
their faces.
So, I would much prefer if this feature is optional.
i.e. add something like:
```
int gsm48_encode_bearer_cap2(struct msgb *msg, int lv_only, bool with_3a,
const struct gsm_mncc_bearer_cap *bcap);
```
Then the behavior does not change for clients out there,
and callers can switch to the new behavior in a controlled way.
(I would then later encourage that you add a config option to osmo-msc to choose between
old and new behavior, so users can decide whether to include 3a or not. maybe like this?
```
msc
gsm-bearer-cap (default|support-legacy)
```
where 'default' means what current master does;
and 'support-legacy' means this patch's behavior.)
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36784?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia09abb32a8458384151a6ae28744835ea440fc5b
Gerrit-Change-Number: 36784
Gerrit-PatchSet: 7
Gerrit-Owner: nt2mku <degrunert.web(a)googlemail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: falconia <falcon(a)freecalypso.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: nt2mku <degrunert.web(a)googlemail.com>
Gerrit-Comment-Date: Tue, 28 May 2024 20:13:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment