Attention is currently required from: nt2mku.

View Change

1 comment:

• Patchset:

  • Patch Set #7:

    Let's ensure test stability:

    Our ttcn3 tests and possibly clients of libosmocore in regression tests expect specific PDUs in specific scenarios. If we change the implicit behavior, then tests may fall on their faces.

    So, I would much prefer if this feature is optional.
    i.e. add something like:
    ```
    int gsm48_encode_bearer_cap2(struct msgb *msg, int lv_only, bool with_3a,
                                 const struct gsm_mncc_bearer_cap *bcap);
    ```

    Then the behavior does not change for clients out there,
    and callers can switch to the new behavior in a controlled way.

    (I would then later encourage that you add a config option to osmo-msc to choose between old and new behavior, so users can decide whether to include 3a or not. maybe like this?
    ```
    msc
     gsm-bearer-cap (default|support-legacy)
    ```
    where 'default' means what current master does;
    and 'support-legacy' means this patch's behavior.)

To view, visit change 36784. To unsubscribe, or for help writing mail filters, visit settings.