Attention is currently required from: neels.
laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40198?usp=email )
Change subject: personalization: implement reading back values from a PES ......................................................................
Patch Set 6: Code-Review-1
(1 comment)
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/40198/comment/c352d841_200e6677?usp=ema... : PS6, Line 56: de this is somewhat of a copy of pySim.esim.saip.File.file_content_from_tuples, and I think it's a dangerously incomplete one as it does not understand anything about default file contents "inherited" from the specific file template that may be used for a file.
In general I think the proper approach for this is to simply use the existing high-level infrsatructure from the @File()@ instances that are attached to the ProfileElementSeequence, rather than doing a functionally limited re-implementation of it here.
The added benefit is reduced code duplication, but even more relevant: You get the proper default file contents from the filesystem template, if any was used by the specific input profile.