Attention is currently required from: daniel, msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/30638 )
Change subject: oc2gbts_mgr_calib: fix build against gpsd >= 3.20 ......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
Also, do we really need to support multiple gpsd versions with this? […]
I thought so too at first, but it was noted in a related code review that we do need to have backwards compatibility to multiple gpsd versions: https://gitea.sysmocom.de/sysmocom/gpsdate/pulls/1#issuecomment-68
Also there's already code in this file supporting other gpsd versions.
File src/osmo-bts-oc2g/misc/oc2gbts_mgr_calib.c:
https://gerrit.osmocom.org/c/osmo-bts/+/30638/comment/02379276_0d9a0794 PS3, Line 174: #if GPSD_API_MAJOR_VERSION >= 9 && GPSD_API_MINOR_VERSION >= 0
I don't think there're negative minor versions so we can simply check the major version alone 😊
True, the "&& GPSD_API_MINOR_VERSION >= 0" part doesn't do anything - removed it.