20 Jul
2022
20 Jul
'22
5:43 p.m.
Attention is currently required from: pespin, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28678 )
Change subject: trxcon: support handling of multiple L1CTL client connections ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_server.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/28678/comment/66e160f5_f9eaf4bf PS1, Line 39: unsigned int index;
idx?
I don't get this comment. does it matter if it's index or idx? Or are you requesting the naming to be consistent between struct member and function argument names?
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28678
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Id92e5b553487e4cf10ea291b487a3ef0c65d72ae
Gerrit-Change-Number: 28678
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter pmaier@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Wed, 20 Jul 2022 17:43:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment