[S] Change in pysim[master]: personalization: set default values

Attention is currently required from: neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40094?usp=email ) Change subject: personalization: set default values ...................................................................... Patch Set 4: Code-Review-1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/pysim/+/40094/comment/5a0d0620_f6c77562?usp=em… : PS2, Line 11: This is useful for user interaction, to prefill an input field that : indicates a valid input to modify to taste. For parameters that actually have a sane default value, I agree it makes sense to have them stored here. But for those that do not, or even worse, where a default would have critical security implications, there should not be a default. If you want to indicate an input format or an example, then that would be an "example content" or "input format" class member, but no a default value. File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/40094/comment/4485aa83_dbc8ae5a?usp=em… : PS2, Line 278: default_value there is never any use case for an all-zero ICCID. I don't see why we should add that in the code and why it should provide any advantage. If you want to specify length constraints, then that is what max_len and min_len are for. That is the actual "useful indicator for number of digits" as expressed by this class. Any code that wants to use that information in some kind of UI can use that. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40094?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2672fedcbc32cb7a6cb0c233a4a22112bd9aae03 Gerrit-Change-Number: 40094 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 06 Aug 2025 12:19:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>