Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30111 )
Change subject: fix sdp_msg_to_sdp_str(), never add fmtp for unset codec ......................................................................
Patch Set 1:
(1 comment)
File src/libmsc/sdp_msg.c:
https://gerrit.osmocom.org/c/osmo-msc/+/30111/comment/1c59d526_16fe6156 PS1, Line 271: if (!sdp_audio_codec_is_set(codec))
""" […]
this patch is really not that important, it is just something that "fell out" when i separated the code bomb resulting from experimental hacking on codecs into smaller chunks. i think this could be dropped ... but why bother, this is trivial.
the most significant difference is the added 'continue;' The old code would print "a=fmtp..." even if subtype_name[0] == 0.
There is no real practical implication, normally the audio_codecs->count indicates the actually populated entries and there shouldn't be empty entries among those.