Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33703 )
Change subject: osmo-bts-trx: pull the AMR header in tch_dl_dequeue() ......................................................................
Patch Set 2:
(1 comment)
File src/osmo-bts-trx/sched_lchan_tchf.c:
https://gerrit.osmocom.org/c/osmo-bts/+/33703/comment/c7c1442a_30b22b90 PS2, Line 406: msg_tch->l2h += sizeof(struct amr_hdr);
maybe assert that len > sizeof(struct amr_hdr).
`osmo_amr_rtp_dec()` ensures that msgb has enough data in it, not only `struct amr_hdr` but also as much payload bytes as needed for the indicated `AMR FT`. So this is not really needed, we return early above if msgb is incomplete.