Attention is currently required from: Hoernchen.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/30633 )
Change subject: logging: add log level cache
......................................................................
Patch Set 6: Code-Review+1
(2 comments)
Patchset:
PS5:
...that was -O3, it still exists for O3, however.
thanks for trying and explaining. This leaves us with the #if/#endif approach or
some magic macro-for-functioncalls-which-gets-defined-away-on-embedded. But that's
not really less evil.
For the static functions log_cache_check() and log_cache_update_all() the
#ifdef-inside-function-body trick should work though.
The logging/vty code and it's lack of abstraction plus the not-so-ideal interface
between libosmocore and libosmovty goes back to the very early days of openbsc/osmo-nitb.
File tests/bitgen/bitgen_test.c:
https://gerrit.osmocom.org/c/libosmocore/+/30633/comment/a522f896_7484a6b9
PS6, Line 17: SIZE
unrelated changes?
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/30633
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I35f8dd9127dd6e7feae392094fd6b3ce2d32558d
Gerrit-Change-Number: 30633
Gerrit-PatchSet: 6
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 16 Dec 2022 22:47:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment