Attention is currently required from: pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/40432?usp=email )
Change subject: gtpie: make ies const for getter ......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/gtp/gtpie.h:
https://gerrit.osmocom.org/c/osmo-ggsn/+/40432/comment/6524e19c_c7ac77d6?usp... : PS1, Line 304: extern int gtpie_getie(union gtpie_member * const ie[], int type, int instance);
Ah nevermind, it's an out param right?
No, it returns the output for getie(). But I tried to change it to "const union gtpie_member * const ie[]" which doesn't work. I'm not sure, problably, because it expects the objects within ie[] to be const which is a different type. Any other recommendation?
here is the output of gcc ``` gtp.c:2160:34: error: passing argument 1 of 'gtpie_gettv4' from incompatible pointer type [-Wincompatible-pointer-types] 2160 | if (gtpie_gettv4(ie, GTPIE_CHARGING_ID, 0, &pdp->cid)) { | ^~ | | | union gtpie_member ** ../include/osmocom/gtp/gtpie.h:314:58: note: expected 'const union gtpie_member * const*' but argument is of type 'union gtpie_member **' 314 | extern int gtpie_gettv4(union gtpie_member const * const ie[], int type, int instance, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~ ```