Attention is currently required from: fixeria, pespin.
osmith has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375?usp=email )
Change subject: ss7 vty: Fix insert order of routes with higher priority
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
File src/osmo_ss7.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/ef2f12e9_ed0c1…
:
PS3, Line 736: return -ENODEV;
I prefer keeping it this way since the typology of
return is different here. […]
Acknowledged
File src/osmo_ss7_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375/comment/c70ef940_748fb…
:
PS3, Line 401: find
The real only expected cause of this failing here is
that the linkset cannot be found, so it's far m […]
Acknowledged
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/38375?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I6e7b5e3f06ae2c9468da58c55d2f42cbcd777218
Gerrit-Change-Number: 38375
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 10 Oct 2024 15:16:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>