Attention is currently required from: pespin, fixeria.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/30523
)
Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload
......................................................................
Patch Set 4:
(2 comments)
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/30523/comment/9ba2f3e7_57deb2ca
PS3, Line 1915: * reception depending on what the particular BTS model supports. In case
no preference is set, it will be
I'd go for explicitly setting supported values in
each bts_model, and avoid code paths where we end […]
I thought about this but I
don't know the formats for all BTS models. I think for all those sysmo-bts like models
we can assume that it is TS 101.319 but what about octbts? I am not sure.
https://gerrit.osmocom.org/c/osmo-bts/+/30523/comment/acf971f1_33218f41
PS3, Line 1924: * byte TOC header in frond of the audio payload. (See also: RFC 5993,
section 5.2) */
typo: front
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/30523
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I17f0b546042fa333780fd2f5c315898ab0df574c
Gerrit-Change-Number: 30523
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 13 Dec 2022 14:43:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment