Attention is currently required from: laforge.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37010?usp=email )
Change subject: esim.saip: Add ProfileElementSequence.remove_naas_of_type ......................................................................
Patch Set 4: Code-Review+1
(2 comments)
File pySim/esim/saip/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/37010/comment/351326ab_1337481d PS3, Line 562: def remove_naas_of_type(self, naa: Naa) -> None:
I don't like printing by library functions in general, this kind of code might very well be executed […]
a list of items that were removed could be returned... but it's not that important, marking as resolved.
https://gerrit.osmocom.org/c/pysim/+/37010/comment/b915c31c_68dc1e43 PS3, Line 573: if template in hdr.decoded['eUICC-Mandatory-GFSTEList']: : hdr.decoded['eUICC-Mandatory-GFSTEList'] = [x for x in hdr.decoded['eUICC-Mandatory-GFSTEList'] if not template.prefix_match(x)]
I'm not following you here, sorry.
I thought if this could possibly miss entries, if `template.prefix_match(x)` is True, but for some reason `template in hdr.decoded[...]` is False. But probably not, nvm.