pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/33307 )
Change subject: Use new mgcp_client_conf_alloc() API to alloc mgcp_client_conf
......................................................................
Use new mgcp_client_conf_alloc() API to alloc mgcp_client_conf
Depends: osmo-mgw.git Change-Id Iba0853ed099a32cf1dde78c17e1b34343db41cfc
Change-Id: I0f142e7af180136e8dac142672d38d75a76ef123
---
M TODO-RELEASE
M src/osmo-hnbgw/hnbgw.c
2 files changed, 12 insertions(+), 3 deletions(-)
Approvals:
osmith: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/TODO-RELEASE b/TODO-RELEASE
index ae5d20f..10cb13b 100644
--- a/TODO-RELEASE
+++ b/TODO-RELEASE
@@ -10,5 +10,5 @@
osmo-hnbgw cfg config deprecated: 'sccp cr max-payload-len <0-999999>'
libosmo-sigtran >=1.7.0 Ensure SCCP CR max payload length of 130 bytes is enforced.
Uses osmo_scu_prim_hdr_name_c()
-libosmo-mgcp-client > 1.11.0 mgcp_client_pool_empty()
+libosmo-mgcp-client > 1.11.0 mgcp_client_pool_empty(), mgcp_client_conf_alloc()
libosmo-sigtran >1.7.0 Require presence of vty 'cs7 instance'/'sccp
max-optional-data' that the deprecated+fatal 'hnbgw'/'sccp cr...'
tells the user to use instead.
diff --git a/src/osmo-hnbgw/hnbgw.c b/src/osmo-hnbgw/hnbgw.c
index 0d64adf..e76dfde 100644
--- a/src/osmo-hnbgw/hnbgw.c
+++ b/src/osmo-hnbgw/hnbgw.c
@@ -56,8 +56,7 @@
INIT_LLIST_HEAD(&g_hnbgw->sccp.users);
g_hnbgw->mgw_pool = mgcp_client_pool_alloc(g_hnbgw);
- g_hnbgw->config.mgcp_client = talloc_zero(g_hnbgw, struct mgcp_client_conf);
- mgcp_client_conf_init(g_hnbgw->config.mgcp_client);
+ g_hnbgw->config.mgcp_client = mgcp_client_conf_alloc(g_hnbgw);
#if ENABLE_PFCP
g_hnbgw->config.pfcp.remote_port = OSMO_PFCP_PORT;
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/33307
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I0f142e7af180136e8dac142672d38d75a76ef123
Gerrit-Change-Number: 33307
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged