Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32212 )
Change subject: NM: NACK received OML OPSTART if no attributes were set beforehand ......................................................................
Patch Set 2:
(2 comments)
File src/common/nm_bb_transc_fsm.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32212/comment/ff12f4a9_89c55d05 PS2, Line 139: SITE_MGR You meant BASEBAND TRANSCEIVER here? Are there any attributes for it in the OML spec? I see none in section 6.5, so IMO this code chunk will always remain no-op.
File src/common/nm_bts_sm_fsm.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32212/comment/170263e8_299d87c6 PS2, Line 103: SITE_MGR Are there any attributes for it in the OML spec? I see none in section 6.5, so IMO this code chunk will always remain no-op.