Attention is currently required from: neels.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/30117
)
Change subject: [codecs filter] add trans.cc.codecs
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
see the list of [codecs filter] patches; i could merge
all of those to one patch, but it would make […]
I'm happy that you are
splitting patches, don't make me wrong. But perhaps this specific code should go
inside the first one which actually uses that variable.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/30117
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ib3fdeff8d1e1ea0760168d63ee6e1b1fb993aa5f
Gerrit-Change-Number: 30117
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 17 Nov 2022 11:21:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment