[S] Change in osmo-mgw[master]: iuup: Increment RTP hdr seqnr even if Tx over UDP fails

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36632?usp=email ) Change subject: iuup: Increment RTP hdr seqnr even if Tx over UDP fails ...................................................................... iuup: Increment RTP hdr seqnr even if Tx over UDP fails This way holes can be detected. In practice it's not much important since it would be really strange that UDP fails for a while and then it starts working out of the blue... Related: SYS#6907 Change-Id: I8095f3505c859650c0b83abce405067bef745975 --- M src/libosmo-mgcp/mgcp_iuup.c 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/libosmo-mgcp/mgcp_iuup.c b/src/libosmo-mgcp/mgcp_iuup.c index d6f164d..4832ddc 100644 --- a/src/libosmo-mgcp/mgcp_iuup.c +++ b/src/libosmo-mgcp/mgcp_iuup.c @@ -505,6 +505,7 @@ hdr->timestamp = osmo_htonl(mgcp_get_current_ts(rtp_end->codec->rate)); hdr->sequence = osmo_htons(rtp_state->alt_rtp_tx_sequence); hdr->ssrc = rtp_state->alt_rtp_tx_ssrc; + rtp_state->alt_rtp_tx_sequence++; LOGPENDP(endp, DRTP, LOGL_DEBUG, "process/send IuUP to %s %s rtp_port:%u rtcp_port:%u\n", @@ -521,7 +522,6 @@ rtpconn_rate_ctr_add(conn_dst, endp, RTP_PACKETS_TX_CTR, 1); rtpconn_rate_ctr_add(conn_dst, endp, RTP_OCTETS_TX_CTR, buflen); - rtp_state->alt_rtp_tx_sequence++; return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/36632?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I8095f3505c859650c0b83abce405067bef745975 Gerrit-Change-Number: 36632 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged