Attention is currently required from: JPM, dexter.
fixeria has posted comments on this change by JPM. (
https://gerrit.osmocom.org/c/pysim/+/38992?usp=email )
Change subject: Handling Long APDU response
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/pysim/+/38992/comment/6c539209_9610c578?usp=em… :
PS1, Line 7: Handling Long APDU response
Please change to `modem_atcmd: Handling Long APDU response` so that the commit message
clearly tells where you're adding handling of long APDU response(s).
File pySim/transport/modem_atcmd.py:
https://gerrit.osmocom.org/c/pysim/+/38992/comment/f6631eb8_7682131f?usp=em… :
PS1, Line 172: b'CME ERROR:'
You're removing the `+` sign here (was `b'+CME ERROR:'`), is this
intentional?
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/38992?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I3c09d4dd1ed68bb982e23c90a6762fd9c2dfdd7f
Gerrit-Change-Number: 38992
Gerrit-PatchSet: 1
Gerrit-Owner: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: JPM <jean-pierre.marcotte.1(a)ens.etsmtl.ca>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 03 Dec 2024 11:34:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No