[M] Change in pysim[master]: contrib/es9p_client: Add support for reporting notifications to SM-DP+

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37499?usp=email ) Change subject: contrib/es9p_client: Add support for reporting notifications to SM-DP+ ...................................................................... Patch Set 3: (4 comments) File pySim/esim/__init__.py: https://gerrit.osmocom.org/c/pysim/+/37499/comment/a126df97_f2fefdbd PS3, Line 7: pmo4operation Looks like you want this to be an `enum.IntEnum`? ``` class PMO(IntEnum): INSTALL = 0x80 ENABLE = 0x40 ... ``` This gives you int/enum conversion API out of box. Not critical. https://gerrit.osmocom.org/c/pysim/+/37499/comment/bda6ef1e_4d4b1396 PS3, Line 23: _num_bits FYI, this can be implemented as: * `data.bit_count()` - (Python 3.10 or later) * `bin(data).count("1")` - (Python 3.9 or earlier) https://gerrit.osmocom.org/c/pysim/+/37499/comment/a84922e9_5535b32e PS3, Line 35: from_int If this class was an `enum.IntEnum`, this API would look like: ``` def from_int(cls, i: int): cls(i) ``` https://gerrit.osmocom.org/c/pysim/+/37499/comment/abbc4c44_b264806c PS3, Line 35: str `str` is not a valid type hint for this function, should be `-> 'PMO'` I think -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37499?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iefba7fa0471b34eae30700ed43531a515af0eb93 Gerrit-Change-Number: 37499 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 16 Jul 2024 22:28:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment