Attention is currently required from: Hoernchen, laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/28513 )
Change subject: host/cardem: fix integer overflow in process_do_rx_da()
......................................................................
Patch Set 4:
(2 comments)
This change is ready for review.
File host/src/simtrace2-cardem-pcsc.c:
https://gerrit.osmocom.org/c/simtrace2/+/28513/comment/457cb0e6_92110d93
PS3, Line 170: if (rc < 0)
The point is that at this point we cannot possibly continue, as we don't know if we should continue […]
Done
https://gerrit.osmocom.org/c/simtrace2/+/28513/comment/618aefbf_cfee4410
PS3, Line 203: else if
certainly not, as we don't know if rx or tx is the next step in the communication. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/simtrace2/+/28513
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I9e97b955a28ec886a429d744f9316e7e71be4481
Gerrit-Change-Number: 28513
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: Hoernchen
ewild@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Attention: Hoernchen
ewild@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Comment-Date: Mon, 11 Jul 2022 09:50:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Gerrit-MessageType: comment
