28 Mar
2023
28 Mar
'23
8:02 p.m.
Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32087 )
Change subject: Introduce LOGPLCFN() for logging lchan-name + frame number ......................................................................
Patch Set 3:
(1 comment)
File src/common/measurement.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32087/comment/7e1c797f_f69097e3 PS3, Line 76: LOGPLCFN(lchan, DMEAS, LOGL_ERROR, fn, "Unsupported lchan->tch_mode %u\n", This is totally weird. You are passing lchan before DMEAS and LOGL_ERROR, but "fn" afterwards. Please put both paramters at the same place.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32087
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I214af0448652a9f321ccbab77977b67663ba28f9
Gerrit-Change-Number: 32087
Gerrit-PatchSet: 3
Gerrit-Owner: laforge laforge@osmocom.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Comment-Date: Tue, 28 Mar 2023 09:02:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment