Attention is currently required from: dexter, laforge.
fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/39199?usp=email )
Change subject: global_platform: add new command "install_cap" ......................................................................
Patch Set 8: Code-Review+1
(2 comments)
File docs/cap-tutorial.rst:
https://gerrit.osmocom.org/c/pysim/+/39199/comment/33ed55df_7175f973?usp=ema... : PS7, Line 5: support
Done
The phrasing is still weird here. You write "cards [do] support ... support" (support twice). The "do support" was fine, I would remove the second "support".
File pySim/global_platform/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/39199/comment/1b671f5b_96633546?usp=ema... : PS8, Line 865: add_mutually_exclusive_group() Do we require at least one argument to be supplied? Or not? (Asking to be sure)