Attention is currently required from: falconia, fixeria, laforge.
pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-abis/+/39731?usp=email )
Change subject: trau: new function osmo_trau2rtp_ufe()
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
File src/trau/trau_rtp_conv.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/52c8a59b_69e3b127?... :
PS2, Line 137: * \param[in] emit_twts001 self-explanatory
It may be self explanatory to you, but no to others. […]
Done
https://gerrit.osmocom.org/c/libosmo-abis/+/39731/comment/13363978_8e0407ae?... :
PS2, Line 359:
I disagree: I intentionally designed the new `osmo_trau2rtp_ufe()` API to set `*ufe` to true if a UF […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-abis/+/39731?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I7a90eca296b17b1211e5c2125fb1496cd362e1c9
Gerrit-Change-Number: 39731
Gerrit-PatchSet: 3
Gerrit-Owner: falconia
falcon@freecalypso.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: falconia
falcon@freecalypso.org
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Wed, 12 Mar 2025 20:14:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: falconia
falcon@freecalypso.org
Comment-In-Reply-To: pespin
pespin@sysmocom.de
