Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/27871 )
Change subject: firmware/apps/rssi: fix -Wmaybe-uninitialized in handle_pm()
......................................................................
Patch Set 1:
(1 comment)
File src/target/firmware/apps/rssi/main.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/27871/comment/733d89d5_af900fe4
PS1, Line 923: } else { /* mode == MODE_SPECTRUM */
maybe actually use a switch?
No, I see no
benefits of using switch for handling two possible values.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/27871
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I86d241c41d4de135f4cd79f56f7fdd18696b7890
Gerrit-Change-Number: 27871
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Apr 2022 13:17:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment