15 Feb
2025
15 Feb
'25
7:18 p.m.
Attention is currently required from: lynxis lazus, pespin.
laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/38945?usp=email )
Change subject: iu_client: refactor LAC/RAC handling ......................................................................
Patch Set 6: Code-Review+1
(1 comment)
File src/iu_client.c:
https://gerrit.osmocom.org/c/osmo-iuh/+/38945/comment/3bd8d947_333e0cc5?usp=... : PS4, Line 453: ra_id.rac = 0xfe;
I switched to 0xff which is invalid. Also rejecting such RAC.
I've never seen (or at least Do not recall) ever seeing anything about 0xFE being a reserved RAC. For the LAC, yes, 0xFFFF, 0xFFFE and 0x0000 ar reserved or have special meaning.
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/38945?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: Ie38fa3751cfce1c981d8d0bed1b8ff891593a638
Gerrit-Change-Number: 38945
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus lynxis@fe80.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: daniel dwillmann@sysmocom.de
Gerrit-CC: neels nhofmeyr@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: lynxis lazus lynxis@fe80.eu
Gerrit-Comment-Date: Sat, 15 Feb 2025 19:18:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin pespin@sysmocom.de
Comment-In-Reply-To: lynxis lazus lynxis@fe80.eu