Attention is currently required from: fixeria, osmith, pespin.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/37681?usp=email )
Change subject: drop config.vty tests from make check
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS2:
Maybe some parts of this test can be moved to
libosmo-sccp. […]
well the intention was to test whether osmo-hnbgw starts up in the
expected way.
A test in libosmo-sccp would verify that the API is doing what it says,
but here i want to test whether osmo-hnbgw is using the API correctly.
We can always have *additional* tests in libosmo-sccp?
PS2:
Ack. Maybe just a comment in `Makefile.am`. […]
the README.md seems very generic / user oriented.
Added a comment in the Makefile.am instead.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/37681?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I9c1540904b13d25db1c7933a88f6cc4b028fdd2b
Gerrit-Change-Number: 37681
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 03 Aug 2024 01:17:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment