21 Jul
2022
21 Jul
'22
9:23 a.m.
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28704 )
Change subject: Use cbc_{cbsp,sbcap}_link_close when possible ......................................................................
Patch Set 1:
(1 comment)
File src/cbsp_link.c:
https://gerrit.osmocom.org/c/osmo-cbc/+/28704/comment/feb551a9_174aa4bf PS1, Line 155: cbc_cbsp_link_close(link);
Unrelated: looks like we leak memory here. I think we need to: […]
No we don't. this function calls osmo_stream_srv_close(), which calls the close_cb (cbsp_cbc_closed_cb) which sends CBSP_LINK_E_CMD_CLOSE to the FSM which terminates it, and the cleanup_cb of the fsm frees everything.
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28704
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: Ie020b9b5ee93ae8d0c9e7266177728185e8635f2
Gerrit-Change-Number: 28704
Gerrit-PatchSet: 1
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Thu, 21 Jul 2022 09:23:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Gerrit-MessageType: comment